feat: add a Docker HEALTHCHECK for the daemon - #18
Merged
Conversation
The distroless image has no shell or curl, so add a `riskkernel healthcheck` subcommand that GETs /healthz and exits non-zero when unhealthy, and wire it into the Dockerfile HEALTHCHECK. Lets orchestrators see container health. Fixes #14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker image had no
HEALTHCHECK, so orchestrators couldn't tell when the container was healthy. Since the distroless image has no shell or curl, this adds ariskkernel healthchecksubcommand (GETs/healthz, exits non-zero when unhealthy) and wires it into the DockerfileHEALTHCHECK.Fixes #14
Verified locally:
riskkernel healthcheckexits 1 when the daemon is down and 0 when it's up.